Skip to content

ci: allow dependabot PRs to skip deployments to cloudflare#1235

Merged
fhammerschmidt merged 7 commits intomasterfrom
vlk/allow-dependabot-to-merge
Apr 8, 2026
Merged

ci: allow dependabot PRs to skip deployments to cloudflare#1235
fhammerschmidt merged 7 commits intomasterfrom
vlk/allow-dependabot-to-merge

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented Apr 7, 2026

image

This pull request updates the deployment workflow to prevent certain steps from running when the workflow is triggered by Dependabot. Specifically, the deployment and pull request comment steps will now be skipped if the actor is Dependabot.

Workflow condition updates:

  • Added a condition to the "Deploy" step in .github/workflows/deploy.yml so it does not run when the workflow is triggered by dependabot[bot].
  • Added a similar condition to the "Comment PR with deployment link" step to skip commenting when triggered by dependabot[bot].

GitHub restricts secrets for pull_request events triggered by
dependabot[bot]. Switch dependabot PRs to pull_request_target,
which runs in the base branch context and has access to secrets.

- Add pull_request_target trigger
- Route dependabot PRs through pull_request_target only
- Route all other PRs through pull_request only (no double runs)
- Checkout PR head SHA for pull_request_target events

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jderochervlk jderochervlk changed the title ci: allow dependabot PRs to deploy via pull_request_target ci: allow dependabot PRs to skip deployments to cloudflare Apr 7, 2026
@jderochervlk jderochervlk marked this pull request as ready for review April 7, 2026 19:36
@jderochervlk jderochervlk requested a review from Copilot April 7, 2026 19:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Cloudflare deployment

Deployement ID: ebe8e590-bda1-4041-b6cc-b30f3c016503
Deployment Environment: preview

⛅️ wrangler 4.63.0 (update available 4.81.0)
─────────────────────────────────────────────
✨ Compiled Worker successfully
Uploading... (7656/7658)
Uploading... (7657/7658)
Uploading... (7658/7658)
✨ Success! Uploaded 2 files (7656 already uploaded) (3.90 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://ebe8e590.rescript-lang.pages.dev
✨ Deployment alias URL: https://vlk-allow-dependabot-to-merg.rescript-lang.pages.dev

@fhammerschmidt fhammerschmidt merged commit ce8ce7a into master Apr 8, 2026
5 checks passed
@fhammerschmidt fhammerschmidt deleted the vlk/allow-dependabot-to-merge branch April 8, 2026 09:29
jderochervlk added a commit that referenced this pull request Apr 9, 2026
* ci: allow dependabot PRs to skip deployments to cloudflare (#1235)

* ci: allow dependabot PRs to deploy via pull_request_target

GitHub restricts secrets for pull_request events triggered by
dependabot[bot]. Switch dependabot PRs to pull_request_target,
which runs in the base branch context and has access to secrets.

- Add pull_request_target trigger
- Route dependabot PRs through pull_request_target only
- Route all other PRs through pull_request only (no double runs)
- Checkout PR head SHA for pull_request_target events

* Update .github/workflows/deploy.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* bypass cloudflare

* Simplify deploy job condition in workflow file

* Fix conditional syntax in deploy workflow steps

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: patch marked ReDoS vulnerability (CVE-2022-21681) via Yarn resolution override (#1236)

* Initial plan

* fix: upgrade marked to 4.0.10 via resolutions to fix ReDoS (GHSA-5v2h-r2cx-5xgj)

Agent-Logs-Url: https://github.com/rescript-lang/rescript-lang.org/sessions/9eb986e6-cb64-40d5-ac83-ff5bdd72d561

Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com>

* feat: split community pages out of MdxRoute into CommunityRoute (#1223)

- Create CommunityRoute.res with dedicated loader and community sidebar
- Register communityRoutes in routes.res, filter community from mdxRoutes
- Remove communityTableOfContents, community branches from MdxRoute

* fix: Add .resi file for CommunityRoute.jsx (#1238)

* Add Cypress E2E testing with ReScript bindings and CI integration (#1239)

* Add Cypress E2E testing with ReScript bindings and CI integration

- Add Cypress config and support files for E2E tests
- Add ReScript bindings for Cypress in e2e/bindings
- Add navigation E2E test in e2e/Navigation_.cy.res
- Update .gitignore for e2e artifacts
- Add Cypress and E2E scripts to package.json
- Add e2e to rescript.json dev sources
- Update GitHub Actions to run E2E tests after deploy

* Use Cypress GitHub Action for E2E tests in deploy workflow

* pr feedback

* wait again

* configure retries

* change type name

* Initial plan

---------

Co-authored-by: Josh Vlk <josh@vlkpack.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants